Skip to content

[improve] [txn] respond to client when txn update status to committing or aborting#20065

Closed
TakaHiR07 wants to merge 1 commit intoapache:masterfrom
TakaHiR07:improve_respond_to_client_after_committing
Closed

[improve] [txn] respond to client when txn update status to committing or aborting#20065
TakaHiR07 wants to merge 1 commit intoapache:masterfrom
TakaHiR07:improve_respond_to_client_after_committing

Conversation

@TakaHiR07
Copy link
Contributor

@TakaHiR07 TakaHiR07 commented Apr 11, 2023

Master Issue: #19747

Motivation

Related to issue, endTxn behave as kafka.

When txn status update to committing/aborting, respond success to client.

Modifications

  1. finish future when update txn status to committing/aborting successfully, then asynchronously process committing->committed
  2. retry committing->committed when occur retryable exception
  3. In case of failing to process committing->committed, add a metric to record unexpected nonRetryable exception count when tc is still available

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: TakaHiR07#6

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 11, 2023
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label May 12, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Jul 31, 2023
@TakaHiR07 TakaHiR07 closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants